src/Database/Adapter/Postgres.php (1)

1751-1772: Good nested-path handling; consider aliasing SEARCH/NOT_SEARCH for consistency.

filterObjectPath() + skipping handleObjectQueries() for nested paths makes sense. One gotcha: TYPE_SEARCH/TYPE_NOT_SEARCH uses regexp_replace({$attribute}, ...) without the table alias, which can become ambiguous in joined queries; using {$alias}.{$attribute} would be safer for both simple and nested paths.

Proposed tweak

@@
             case Query::TYPE_SEARCH:
                 $binds[":{$placeholder}_0"] = $this->getFulltextValue($query->getValue());
-                return "to_tsvector(regexp_replace({$attribute}, '[^\w]+',' ','g')) @@ websearch_to_tsquery(:{$placeholder}_0)";
+                return "to_tsvector(regexp_replace({$alias}.{$attribute}, '[^\w]+',' ','g')) @@ websearch_to_tsquery(:{$placeholder}_0)";
 
             case Query::TYPE_NOT_SEARCH:
                 $binds[":{$placeholder}_0"] = $this->getFulltextValue($query->getValue());
-                return "NOT (to_tsvector(regexp_replace({$attribute}, '[^\w]+',' ','g')) @@ websearch_to_tsquery(:{$placeholder}_0))";
+                return "NOT (to_tsvector(regexp_replace({$alias}.{$attribute}, '[^\w]+',' ','g')) @@ websearch_to_tsquery(:{$placeholder}_0))";

tests/unit/Validator/IndexTest.php (1)

328-439: Test coverage is solid; small readability nits.

• $validNestedObjectIndex is asserted false → rename to $invalidNestedObjectIndex.
• Consider using named args for the new Index(...) constructor here (positional booleans are brittle).

Minimal rename

@@
-        $validNestedObjectIndex = new Document([
+        $invalidNestedObjectIndex = new Document([
             '$id' => ID::custom('idx_nested_object'),
             'type' => Database::INDEX_OBJECT,
             'attributes' => ['data.key.nestedKey'],
             'lengths' => [],
             'orders' => [],
         ]);
 
-        $this->assertFalse($validator->isValid($validNestedObjectIndex));
+        $this->assertFalse($validator->isValid($invalidNestedObjectIndex));

src/Database/Database.php (2)

8147-8162: Minor perf/clarity: compute the base attribute once for nested-object query inference.

Right now explode() happens inside the loop; you can compute $baseAttribute once and reuse $queryAttribute consistently.

---

3638-3715: Make base-attribute matching more robust for dot-path indexes (key fallback + case-insensitive compare).

validateAttribute() treats attribute IDs case-insensitively, but createIndex() matches $baseAttr against key with a case-sensitive comparison. That can leave $indexAttributesWithTypes incomplete (and skip length/array adjustments) if callers pass a different case, or if an attribute lacks key.

Proposed tweak (more defensive matching)

-            $baseAttr = $attr;
-            if (\str_contains($attr, '.')) {
-                $baseAttr = \explode('.', $attr, 2)[0] ?? $attr;
-            }
+            $baseAttr = \str_contains($attr, '.')
+                ? \explode('.', $attr, 2)[0]
+                : $attr;
+            $baseAttrLc = \strtolower($baseAttr);

             foreach ($collectionAttributes as $collectionAttribute) {
-                if ($collectionAttribute->getAttribute('key') === $baseAttr) {
+                $collectionAttrKey = (string)$collectionAttribute->getAttribute('key', $collectionAttribute->getId());
+                if (\strtolower($collectionAttrKey) === $baseAttrLc) {
                     $attributeType = $collectionAttribute->getAttribute('type');
                     $indexAttributesWithTypes[$attr] = $attributeType;

#!/bin/bash
set -euo pipefail

# Ensure Adapter::createIndex signature/arity matches this call (and all implementations are updated).
rg -nP '\bfunction\s+createIndex\s*\('
rg -nP '->createIndex\s*\('

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: abnegate
Repo: utopia-php/database PR: 721
File: tests/e2e/Adapter/Scopes/DocumentTests.php:6418-6439
Timestamp: 2025-10-03T02:04:17.803Z
Learning: In tests/e2e/Adapter/Scopes/DocumentTests::testSchemalessDocumentInvalidInteralAttributeValidation (PHP), when the adapter reports getSupportForAttributes() === false (schemaless), the test should not expect exceptions from createDocuments for “invalid” internal attributes; remove try/catch and ensure the test passes without exceptions, keeping at least one assertion.

Learnt from: ArnabChatterjee20k
Repo: utopia-php/database PR: 747
File: src/Database/Adapter/Mongo.php:1449-1453
Timestamp: 2025-10-29T12:27:57.071Z
Learning: In src/Database/Adapter/Mongo.php, when getSupportForAttributes() returns false (schemaless mode), the updateDocument method intentionally uses a raw document without $set operator for replacement-style updates, as confirmed by the repository maintainer ArnabChatterjee20k.

Learnt from: abnegate
Repo: utopia-php/database PR: 721
File: tests/e2e/Adapter/Scopes/AttributeTests.php:1329-1334
Timestamp: 2025-10-03T01:50:11.943Z
Learning: MongoDB has a 1024kb (1,048,576 bytes) limit for index entries. The MongoDB adapter's getMaxIndexLength() method should return this limit rather than 0.

Learnt from: fogelito
Repo: utopia-php/database PR: 763
File: src/Database/Database.php:8671-8751
Timestamp: 2025-11-25T10:46:37.666Z
Learning: In Utopia\Database\Database::processRelationshipQueries, ensure the system select for '$id' is added only when the collection has relationship attributes (i.e., !empty($relationships)), and avoid capturing the unused '$idAdded' from Query::addSelect to satisfy static analysis.

Learnt from: abnegate
Repo: utopia-php/database PR: 731
File: src/Database/Database.php:6987-6988
Timestamp: 2025-10-20T05:29:29.487Z
Learning: In Utopia\Database\Database::convertRelationshipQueries, Many-to-Many filtering does not need the parent collection or a direct junction query: it calls find() on the related collection without skipping relationships, which populates relationship attributes (including the two-way key). Parent IDs are derived from that populated attribute. Therefore, calls should remain convertRelationshipQueries($relationships, $queries).

Learnt from: fogelito
Repo: utopia-php/database PR: 733
File: src/Database/Adapter/MariaDB.php:1801-1806
Timestamp: 2025-10-16T09:37:33.531Z
Learning: In the MariaDB adapter (src/Database/Adapter/MariaDB.php), only duplicate `_uid` violations should throw `DuplicateException`. All other unique constraint violations, including `PRIMARY` key collisions on the internal `_id` field, should throw `UniqueException`. This is the intended design to distinguish between user-facing document duplicates and internal/user-defined unique constraint violations.

Learnt from: ArnabChatterjee20k
Repo: utopia-php/database PR: 613
File: src/Database/Adapter/Postgres.php:1254-1319
Timestamp: 2025-07-01T11:31:37.438Z
Learning: In PostgreSQL adapter methods like getUpsertStatement, complexity for database-specific SQL generation is acceptable when the main business logic is properly separated in the parent SQL adapter class, following the adapter pattern where each database adapter handles its own SQL syntax requirements.

Learnt from: ArnabChatterjee20k
Repo: utopia-php/database PR: 642
File: src/Database/Validator/PartialStructure.php:43-52
Timestamp: 2025-07-30T19:17:53.630Z
Learning: In PartialStructure validator, when filtering for required attributes validation using the $requiredAttributes parameter, $this->attributes should be used instead of the merged $attributes array because this validation is specifically for internal attributes like $createdAt and $updatedAt that are defined in the base Structure class, not collection-specific attributes.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

tests/e2e/Adapter/Scopes/SchemalessTests.php (1)

3155-3155: Consider a more adapter-agnostic method name.

The method is named testSchemalessMongoDotNotationIndexes but lives in a generic SchemalessTests trait that could be used by any schemaless adapter. A name like testSchemalessNestedObjectPathIndexes or testSchemalessDotNotationIndexes would be more consistent with the rest of the trait.